Skip to content

Fix tidy unittest. #106334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 1, 2023
Merged

Fix tidy unittest. #106334

merged 2 commits into from
Jan 1, 2023

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 31, 2022

The tidy unittests weren't compiling due to a change made a long while ago to the Version type.

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2022

r? @jyn514

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2022
@ehuss
Copy link
Contributor Author

ehuss commented Dec 31, 2022

I was thinking of adding tidy's unittests to bootstrap/test.rs, but I'm unsure if it is worth running. Any thoughts on that? I think if we do add it, it might want to be separate from running tidy, if anything to reduce the noise, but also avoid slowing tidy down.

@Mark-Simulacrum
Copy link
Member

Yes, we definitely shouldn't run them as part of tidy -- I think we have a similar-ish split for Cargo (with cargotest vs. cargo itself).

I think we should run them in CI though.

@jyn514
Copy link
Member

jyn514 commented Dec 31, 2022

r=me unless you wanted to add the unittests to CI as part of this PR

@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2022
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 31, 2022
@ehuss ehuss force-pushed the fix-tidy-unittests branch from d100e5b to 59b80f5 Compare December 31, 2022 20:34
@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Dec 31, 2022
@ehuss
Copy link
Contributor Author

ehuss commented Dec 31, 2022

Ok, I added it so that it gets checked in CI.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 31, 2022
@jyn514
Copy link
Member

jyn514 commented Dec 31, 2022

Looks great, thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 31, 2022

📌 Commit 59b80f5 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 31, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 31, 2022
@bors
Auto merge of rust-lang#106336 - matthiaskrgr:rollup-4p6bgwf, r=matth…
c9825f7 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#106280 (docs: add link to `Path::join` in `PathBuf::push`)
 - rust-lang#106297 (rustdoc: merge scrape-help CSS)
 - rust-lang#106328 (Add comment explaining what the GUI scrape-examples-fonts test is about)
 - rust-lang#106334 (Fix tidy unittest.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0b3c3c9 into rust-lang:master Jan 1, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ehuss @rustbot @Mark-Simulacrum @jyn514 @bors